feat: Redesign the active sessions view and rework idletime #2006
+463
−114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2006 +/- ##
==========================================
+ Coverage 84.74% 85.00% +0.25%
==========================================
Files 212 213 +1
Lines 7068 7075 +7
Branches 493 490 -3
==========================================
+ Hits 5990 6014 +24
+ Misses 919 903 -16
+ Partials 159 158 -1 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
API Changelog 4.13.1.dev52+g40de9eb3GET /api/v1/sessions
POST /api/v1/sessions
GET /api/v1/sessions/{session_id}
GET /api/v1/users/{user_id}/sessions
|
|
A Storybook preview is available for commit 40de9eb. |
This comment has been minimized.
This comment has been minimized.
frontend/src/app/general/relative-time/relative-time.component.html
Outdated
Show resolved
Hide resolved
frontend/src/app/general/relative-time/relative-time.component.html
Outdated
Show resolved
Hide resolved
...essions-wrapper/create-sessions/create-session-history/create-session-history.component.html
Outdated
Show resolved
Hide resolved
frontend/src/app/sessions/session-overview/session-overview.component.html
Outdated
Show resolved
Hide resolved
frontend/src/app/sessions/user-sessions-wrapper/active-sessions/active-sessions.component.html
Outdated
Show resolved
Hide resolved
frontend/src/app/sessions/user-sessions-wrapper/active-sessions/active-sessions.component.html
Outdated
Show resolved
Hide resolved
frontend/src/app/sessions/user-sessions-wrapper/active-sessions/active-sessions.component.html
Show resolved
Hide resolved
MoritzWeber0
changed the title
zusorio
force-pushed
the
sessions-redesign
branch
from
dddf4b4 to
6ca7ea3
Compare
This comment has been minimized.
This comment has been minimized.
zusorio
force-pushed
the
sessions-redesign
branch
2 times, most recently
from
868457d to
0115bcf
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
zusorio
force-pushed
the
sessions-redesign
branch
from
0115bcf to
abfcbf5
Compare
This comment has been minimized.
This comment has been minimized.
zusorio
force-pushed
the
sessions-redesign
branch
from
abfcbf5 to
c6f69a4
Compare
This comment has been minimized.
This comment has been minimized.
frontend/src/app/sessions/user-sessions-wrapper/active-sessions/active-sessions.component.html
Show resolved
Hide resolved
Rework idletime: - Renamed idletime to idle_status object - Also return termination time from config - Show card on active session if session will be terminated soon Overhaul parts of the session view: - Show times relative to now - Show session info as one text block instead of split - Redesign last requested session and active session card - Show additional info on active session cards as mini cards Closes #1783 Closes #1486
zusorio
force-pushed
the
sessions-redesign
branch
from
c6f69a4 to
f912ba2
Compare
|
|
This report was generated by comparing 40de9eb with 6a3ca78. ArtifactName:
|
| item | count |
|---|---|
| pass | 337 |
| change | 29 |
| new | 4 |
| delete | 0 |
📝 Report
Differences
Session Components_Active Sessions_Readonly Session Success State_desktop.png
| actual |  |
|---|---|
| expected |  |
| difference |  |
Session Components_Active Sessions_Readonly Session Success State_mobile.png
| actual |  |
|---|---|
| expected |  |
| difference |  |
Session Components_Active Sessions_Session Failed State_desktop.png
| actual |  |
|---|---|
| expected |  |
| difference |  |
Session Components_Active Sessions_Session Failed State_mobile.png
| actual |  |
|---|---|
| expected |  |
| difference |  |
Session Components_Active Sessions_Session Not Found State_desktop.png
| actual |  |
|---|---|
| expected |  |
| difference |  |
Session Components_Active Sessions_Session Not Found State_mobile.png
| actual |  |
|---|---|
| expected |  |
| difference |  |
Session Components_Active Sessions_Session Pending State_desktop.png
| actual |  |
|---|---|
| expected |  |
| difference |  |
Session Components_Active Sessions_Session Pending State_mobile.png
| actual |  |
|---|---|
| expected |  |
| difference |  |
Session Components_Active Sessions_Session Preparation Pending State_desktop.png
| actual |  |
|---|---|
| expected |  |
| difference |  |
Session Components_Active Sessions_Session Preparation Pending State_mobile.png
| actual |  |
|---|---|
| expected |  |
| difference |  |
Session Components_Active Sessions_Session Preparation Running State_desktop.png
| actual |  |
|---|---|
| expected |  |
| difference |  |
Session Components_Active Sessions_Session Preparation Running State_mobile.png
| actual |  |
|---|---|
| expected |  |
| difference |  |
Session Components_Active Sessions_Session Running State_desktop.png
| actual |  |
|---|---|
| expected |  |
| difference |  |
Session Components_Active Sessions_Session Running State_mobile.png
| actual |  |
|---|---|
| expected |  |
| difference |  |
Session Components_Active Sessions_Session Shared With User_desktop.png
| actual |  |
|---|---|
| expected |  |
| difference |  |
Session Components_Active Sessions_Session Shared With User_mobile.png
| actual |  |
|---|---|
| expected |  |
| difference |  |
Session Components_Active Sessions_Session Sharing Enabled_desktop.png
| actual |  |
|---|---|
| expected |  |
| difference |  |
Session Components_Active Sessions_Session Sharing Enabled_mobile.png
| actual |  |
|---|---|
| expected |  |
| difference |  |
Session Components_Active Sessions_Session Terminated State_desktop.png
| actual |  |
|---|---|
| expected |  |
| difference |  |
Session Components_Active Sessions_Session Terminated State_mobile.png
| actual |  |
|---|---|
| expected |  |
| difference |  |
Session Components_Active Sessions_Session Unknown State_desktop.png
| actual |  |
|---|---|
| expected |  |
| difference |  |
Session Components_Active Sessions_Session Unknown State_mobile.png
| actual |  |
|---|---|
| expected |  |
| difference |  |
Session Components_Active Sessions_Session With Feedback Enabled_desktop.png
| actual |  |
|---|---|
| expected |  |
| difference |  |
Session Components_Active Sessions_Session With Feedback Enabled_mobile.png
| actual |  |
|---|---|
| expected |  |
| difference |  |
Session Components_Active Sessions_Shared Session_desktop.png
| actual |  |
|---|---|
| expected |  |
| difference |  |
Session Components_Active Sessions_Shared Session_mobile.png
| actual |  |
|---|---|
| expected |  |
| difference |  |
Session Components_Session History_Resolved Session History.png
| actual |  |
|---|---|
| expected |  |
| difference |  |
Session Components_Session Overview_All Selected_desktop.png
| actual |  |
|---|---|
| expected |  |
| difference |  |
Session Components_Session Overview_Overview_desktop.png
| actual |  |
|---|---|
| expected |  |
| difference |  |
New Items
Session Components_Active Sessions_Session Shared With User Terminating Soon_desktop.png
 |
Session Components_Active Sessions_Session Shared With User Terminating Soon_mobile.png
 |
Session Components_Active Sessions_Session Terminating Soon_desktop.png
 |
Session Components_Active Sessions_Session Terminating Soon_mobile.png
 |
MoritzWeber0
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rework idletime:
Overhaul parts of the session view:
Closes #1783
Closes #1486